Skip to content

Conversation

@Findus23
Copy link
Contributor

@Findus23 Findus23 commented Feb 22, 2025

This might be a slightly opinionated change, so feel free to ignore this PR. But I just wanted to share the changes in case someone else is also interested.
With my headphones all sounds (but especially tone3/4) make an unpleasant (popping?) sound at the start and end because the audio is abruptly cut off.

To fix this, I edited all files to add a 25ms fade-in to all and a 25ms fade-out to tone 3 and 4.
Before:
image
After:
image

@jithware
Copy link
Owner

Sounds good. Will merge if other folks comment on this.

@github-actions
Copy link

github-actions bot commented Aug 8, 2025

This PR is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale label Aug 8, 2025
@github-actions
Copy link

This PR was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this Aug 23, 2025
@Kawys
Copy link
Contributor

Kawys commented Sep 4, 2025

I know this pull request was closed for a while, but I think this is very good change. I don't hear the popping sound at the start of the sounds with my headphones, but cut off at the end of tone 3 & 4 is very noticeable and unpleasant as described by @Findus23 . You can also hear the subtle "pop" at the end of the new tones, but it's definitively change for the better in terms of comfort of use.

@jithware
Copy link
Owner

jithware commented Sep 5, 2025

This can be added. There was a merge conflict after the change in #117. The fix will need to be modified to the new silence removed audio files.

@Findus23
Copy link
Contributor Author

Findus23 commented Sep 5, 2025

Thanks for the reminder, I forgot about this.
I have now applied the same changes to the new audio files and pushed it to the audio-fix branch.
So I think if you reopen this PR it should show up correctly.

@jithware
Copy link
Owner

jithware commented Sep 5, 2025

"Reopen and comment" is disabled stating "The audio-fix branch was force-pushed or recreated". Perhaps checkout new from master and add updated audio files and create a new pull request?

@jithware jithware mentioned this pull request Sep 5, 2025
@jithware
Copy link
Owner

jithware commented Sep 6, 2025

"Reopen pull request" is disabled stating "The audio-fix branch was force-pushed or recreated". Tried checking out pull request #115 directly git fetch origin pull/115/head:pull-115 && git checkout pull-115 and there are merge conflicts in the branch. Unfortunately a new pull request will need to be created or I can download the audio files from audio-fix and add them directly to master. If the later is done then @Findus23 won't get credit for change in release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants