Skip to content

Test 01#24

Merged
mergify[bot] merged 3 commits intounstablefrom
test-01
Nov 9, 2023
Merged

Test 01#24
mergify[bot] merged 3 commits intounstablefrom
test-01

Conversation

@jimmygchen
Copy link
Owner

@jimmygchen jimmygchen commented Nov 9, 2023 •
edited
Loading

  • Test base=unstable queue condition
  • Test label=ready-for-bors queue condition
  • Test #approved-reviews-by >= 1 queue condition
  • Test code conflict with base branch should reject merge
  • Test check-success queue conditions
  • Test check-success merge conditions
  • Test merge queue batche size = 8

@jimmygchen
Copy link
Owner Author

jimmygchen commented Nov 9, 2023

@mergify queue

@mergify
Copy link

mergify bot commented Nov 9, 2023 •
edited
Loading

queue

🟠 Waiting for conditions to match

Details
  • any of: [:twisted_rightwards_arrows: queue conditions]
    • all of: [:pushpin: queue conditions of queue default]
      • #approved-reviews-by >= 1
      • check-success=license/cla
      • label=ready-for-bors
      • base=unstable
      • check-success=target-branch-check
  • -draft [:pushpin: queue requirement]
  • -mergify-configuration-changed [:pushpin: queue -> allow_merging_configuration_change setting requirement]

@jimmygchen jimmygchen changed the base branch from stable to unstable November 9, 2023 00:24
@jimmygchen
Copy link
Owner Author

jimmygchen commented Nov 9, 2023

@mergify queue

@mergify
Copy link

mergify bot commented Nov 9, 2023 •
edited by jimmygchen
Loading

queue

🟠 Waiting for conditions to match

Details
  • any of: [:twisted_rightwards_arrows: queue conditions]
    • all of: [:pushpin: queue conditions of queue default]
      • #approved-reviews-by >= 1
      • check-success=license/cla
      • label=ready-for-bors
      • base=unstable
      • check-success=target-branch-check
  • -draft [:pushpin: queue requirement]
  • -mergify-configuration-changed [:pushpin: queue -> allow_merging_configuration_change setting requirement]

@jimmygchen
Copy link
Owner Author

jimmygchen commented Nov 9, 2023

@mergify queue

@mergify
Copy link

mergify bot commented Nov 9, 2023 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

Details

The pull request conflicts with the base branch.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@jimmygchen
Copy link
Owner Author

jimmygchen commented Nov 9, 2023

@merge queue

@jimmygchen
Copy link
Owner Author

jimmygchen commented Nov 9, 2023

@mergify queue

@mergify
Copy link

mergify bot commented Nov 9, 2023 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

Details

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@jimmygchen
Copy link
Owner Author

jimmygchen commented Nov 9, 2023

@mergify queue

@mergify
Copy link

mergify bot commented Nov 9, 2023

queue

🛑 The pull request has been removed from the queue default

Details

Unexpected queue change: the updated pull request #24 has been manually updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@jimmygchen
Copy link
Owner Author

jimmygchen commented Nov 9, 2023

@mergify queue

@mergify
Copy link

mergify bot commented Nov 9, 2023 •
edited
Loading

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 48523f3

mergify bot added a commit that referenced this pull request Nov 9, 2023
@mergify
Merge of #24
fd4317c
@mergify mergify bot mentioned this pull request Nov 9, 2023
Closed
23 tasks
@mergify mergify bot merged commit 48523f3 into unstable Nov 9, 2023
@jimmygchen jimmygchen deleted the test-01 branch November 9, 2023 01:15
jimmygchen pushed a commit that referenced this pull request Nov 28, 2023
@divagant-martian
Blob syncing (#24)
bf50052 
* add a rt is_blob_batch

* use the mixed type everywhere

* glue

* more glue

* minor fixes

* fix range tests

* filling in the gaps

* moore filling in the gaps
jimmygchen pushed a commit that referenced this pull request Apr 24, 2024
@dapplion
Handle sync lookup request streams in network context (sigp#5583)
f7aca97 
* by-root-stream-terminator

* Fix tests

* Resolve merge conflicts

* Log report reason

* Some lints and bugfixes (#23)

* fix lints

* bug fixes

* Fix tests

* Merge branch 'unstable' of https://github.com/sigp/lighthouse into handle-sync-lookup-requests

* Pr 5583 review (#24)

* add bad state warn log

* add rust docs to new fields in `SyncNetworkContext`

* remove timestamp todo

* add back lookup verify error

* remove TODOs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ready-for-bors

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jimmygchen