Skip to content

Powerpoint writer: use reference-doc font for captions.#10835

Merged
jgm merged 1 commit intojgm:mainfrom
rnwst:fix/9896
May 10, 2025
Merged

Powerpoint writer: use reference-doc font for captions.#10835
jgm merged 1 commit intojgm:mainfrom
rnwst:fix/9896

Conversation

@rnwst
Copy link
Contributor

@rnwst rnwst commented May 10, 2025

I know nothing about PresentationML, nor do I understand much about what is happening in the Haskell code (as it turns out a weekend is not enough to learn Haskell), but this change seems to fix #9896.

@jgm
Copy link
Owner

jgm commented May 10, 2025

Run make TESTARGS=--accept; that should update the golden tests.
Then you might want to open them up with Powerpoint and make sure they look good.

@rnwst
Copy link
Contributor Author

rnwst commented May 10, 2025

Thanks for the tip. I opened the updated files in Powerpoint to compare before/after, and didn't notice any breaking changes. That being said, quite a few of the PPTX files seem to have broken formatting to begin with (see below for an example -- that one's from test/pptx/comparison/extra-image/templated.pptx):
image

@jgm
Copy link
Owner

jgm commented May 10, 2025

Not sure why. But as long as nothing that worked before breaks, we're good.

@jgm jgm merged commit f66481f into jgm:main May 10, 2025
11 of 14 checks passed
christopherkenny pushed a commit to christopherkenny/pandoc that referenced this pull request May 23, 2025
christopherkenny pushed a commit to christopherkenny/pandoc that referenced this pull request May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Figure captions not inheriting master slide font settings

2 participants