RTDEV-62881 - Modify Go pack zip LICENSE for submodules#829
Merged
bhanurp merged 1 commit intojfrog:masterfrom Sep 10, 2025
Merged
RTDEV-62881 - Modify Go pack zip LICENSE for submodules#829bhanurp merged 1 commit intojfrog:masterfrom
bhanurp merged 1 commit intojfrog:masterfrom
Conversation
bhanurp
reviewed
Sep 10, 2025
Comment on lines
+410
to
+422
| if (!entryName.endsWith(LICENSE)) { | ||
| return; | ||
| } | ||
|
|
||
| if (shouldPackSubModule() && entryName.endsWith(subModuleName + "/" + LICENSE)) { | ||
| // use the packing submodule LICENSE | ||
| licensePath = entryName; | ||
| return; | ||
| } | ||
| if (entryName.substring(entryName.indexOf('/') + 1).equals(LICENSE)) { | ||
| // use the root LICENSE | ||
| licensePath = entryName; | ||
| } |
Contributor
There was a problem hiding this comment.
do we need a default case to make sure root license is used
- submodule with LICENSE -> use submodule LICENSE
- submodule without LICENSE -> use root LICENSE
any other scenario use root license?
Contributor
Author
There was a problem hiding this comment.
the default is set to empty string, if it leave that's way, so there is no LICENSE to use.
in case using the root module is handled by the second condition.
in case the entryName is a LICENSE from a submodule that we are not asking for, its won't use it as well
...nfo-extractor-go/src/main/java/org/jfrog/build/extractor/go/extractor/GoZipBallStreamer.java
Outdated
Show resolved
Hide resolved
a0dda0f to
5acf815
Compare
5acf815 to
c6c33f7
Compare
bhanurp
approved these changes
Sep 10, 2025
nitinp19
pushed a commit
to nitinp19/build-info
that referenced
this pull request
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.