Merged
Conversation
lsf37
approved these changes
Oct 19, 2018
Member
lsf37
left a comment
There was a problem hiding this comment.
It looks like they are indeed dead code. Ok to remove from my side.
regisd
pushed a commit
that referenced
this pull request
Oct 20, 2018
Author: Régis Décamps <regisd@google.com>
Date: Sat Oct 20 09:20:07 2018 +0200
Remove dead code ChatSet (#480)
Updated from target/jflex-parent-1.7.1-SNAPSHOT-sources.jar
regisd
pushed a commit
that referenced
this pull request
Oct 20, 2018
Author: Régis Décamps <regisd@google.com>
Date: Sat Oct 20 09:20:07 2018 +0200
Remove dead code ChatSet (#480)
Updated from target/jflex-parent-1.7.1-SNAPSHOT-sources.jar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the dependency graph, CharSet and CharSetEnumerator are unused.
Are they part of the public or dead code?