Split LexGenerator out of Main#428
Merged
regisd merged 6 commits intojflex-de:masterfrom Oct 10, 2018
Merged
Conversation
This is a minor refactoring to support refacotring jflex-de#214 In the future, LexGenerator.generate() will not be static and have internal state in order to support multithreading.
lsf37
approved these changes
Oct 10, 2018
Member
lsf37
left a comment
There was a problem hiding this comment.
Apart from the comment that needs a tweak, everything looks fine.
|
|
||
| /** | ||
| * This is the main class of JFlex controlling the scanner generation process. It is responsible for | ||
| * parsing the commandline, getting input files, starting up the GUI if necessary, etc. |
Member
There was a problem hiding this comment.
The comment will need adjustment for the refactor, indicating which part is in which class in the new setting.
This reverts commit 5d7ae8c. Wrong branch
regisd
pushed a commit
that referenced
this pull request
Oct 10, 2018
Initial commit c3ae263 Author: Régis Décamps <regisd@google.com> Date: Thu Oct 11 00:42:45 2018 +0200 Split LexGenerator out of Main (#428) * Split Main in Main and LexGenerator. This is a minor refactoring to support refacotring #214 In the future, LexGenerator.generate() will not be static and have internal state in order to support multithreading. * Update javadoc *Also Make Main non instanciable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor refactoring to support multithreading #214
Split Main in 2 classes:
Mainthe cli client that parses the command line optionsLexGeneratorthat generates java codeThe later is used by the cli, the jflex-maven-plugin, the ant task and the GUI, i.e.
Main.generate(lexFile)becomesLexGenerator().generate(lexFile)In the future,
LexGenerator.generate()will not be static and have internal state in order to support multithreading.