Conversation
added 6 commits
September 16, 2018 09:44
regisd
reviewed
Sep 16, 2018
Member
regisd
left a comment
There was a problem hiding this comment.
Sorry, I didn't have time to review before you submitted.
| * If true, dot (.) metachar matches [^\n] instead of [^\r\n\u000B\u000C\u0085\u2028\u2029]|"\r\n" | ||
| */ | ||
| public static boolean legacy_dot; | ||
| /** The encoding to use for input files. */ |
Member
Author
There was a problem hiding this comment.
You are right, it'd be better to apply this encoding to both, so that things are consistent. I don't think it's worth doing two separate options, because if somebody wants the output file in a different encoding to the one specified, they can still recode it, as long as it's clear what the output encoding was
| encoding = Charset.forName(encodingName); | ||
| } else { | ||
| Out.error(ErrorMessages.CHARSET_NOT_SUPPORTED, encodingName); | ||
| throw new GeneratorException(); |
Member
There was a problem hiding this comment.
We could default to platform encoding or utd-8 here
Member
Author
There was a problem hiding this comment.
I think it's better to fail if the user provided a specific encoding and it's not available. Otherwise it'd be too easy to overlook and get wrong results.
lsf37
pushed a commit
that referenced
this pull request
Sep 20, 2018
Merged
lsf37
pushed a commit
that referenced
this pull request
Sep 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an encoding option for reading lexer specs. Addresses issue #164.