Rails 4.1. See https://github.com/rails/sprockets-rails/pull/84#178
Merged
jfirebaugh merged 3 commits intojfirebaugh:masterfrom May 24, 2014
Merged
Rails 4.1. See https://github.com/rails/sprockets-rails/pull/84#178jfirebaugh merged 3 commits intojfirebaugh:masterfrom
jfirebaugh merged 3 commits intojfirebaugh:masterfrom
Conversation
Collaborator
|
One only has to keep in mind that konacha must be required in development and testing environment only. Otherwise this would lead to a lot of precompilations. Perhaps there should be a warning in the case of the production environment. |
Contributor
Author
|
Figured out how to test this. Added appropriate commits. |
Contributor
Author
|
@jnbt indeed, although I think that's a separate problem. Konacha's documentation already mentions adding the gem to the |
Contributor
Author
|
Hmm...? The build passed, but it appears as non-passing here. Someone care to replay it? |
jfirebaugh
added a commit
that referenced
this pull request
May 24, 2014
Rails 4.1. See rails/sprockets-rails#84
Owner
|
Thanks, released in 3.2.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #176, caused by a change on Rails 4.1.
Rails 4.1 actively verifies that any assets served on development can actually be served on production. This behaviour is controlled by the config setting
app.config.assets.raise_runtime_errors, which by default isfalseon test andtrueon other environments. See rails/sprockets-rails#84 for discussion.JS tests don't fulfil this requirement because they are not listed for precompilation. Simply setting
raise_runtime_errorstofalsewould not be a good solution, as users would be back to not noticing when their assets won't work on production.Instead, this commit solves the problem by adding the test files to the precompilation list.