Refactor CrossOriginFilter with small perf improvements#4672
Merged
gregw merged 2 commits intojetty:jetty-10.0.xfrom Mar 16, 2020
Merged
Refactor CrossOriginFilter with small perf improvements#4672gregw merged 2 commits intojetty:jetty-10.0.xfrom
gregw merged 2 commits intojetty:jetty-10.0.xfrom
Conversation
99874e7 to
904cd38
Compare
Signed-off-by: Denny Abraham Cheriyan <dennyac@gmail.com>
904cd38 to
3c4ab14
Compare
Contributor
Author
|
Will look into the build issues and resolve it. |
Signed-off-by: Denny Abraham Cheriyan <dennyac@gmail.com>
Contributor
Author
|
Fixed checkstyle violation |
gregw
approved these changes
Mar 16, 2020
Contributor
gregw
left a comment
There was a problem hiding this comment.
Nice!
Ultimately we probably should look to use our IncludeExcludeSet mechanism here, but this is a good improvement within the same semantic.
I think this is also worthwhile in jetty-9.4, so I will merge and then cherry-pick back.
gregw
pushed a commit
that referenced
this pull request
Mar 16, 2020
* Refactor CrossOriginFilter Signed-off-by: Denny Abraham Cheriyan <dennyac@gmail.com> * Fix checkstyle violation Signed-off-by: Denny Abraham Cheriyan <dennyac@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi maintainers,
I've made a small change to split the list of origins into a set of origins (for exact match) and a list of patterns (for pattern match). This way for exact match we can check if the set contains the origin (instead of iterating through the list) and only iterate through the origins for pattern matching.
This change also creates patterns during the init phase, instead of creating a new Pattern object during each request
Functionality remains unchanged. Not sure if any tests need to be added, but do let me know if any specific tests are required.
Force pushed for adding signoff