Merged
Conversation
Contributor
Author
|
@lachlan-roberts Can you give this a read over? For brevity I only listed two OpenID providers (Google and Amazon), as I figured they were the most common. Also, I wanted to verify nothing had changed since your last comments on the issue. |
lachlan-roberts
approved these changes
Feb 26, 2020
Contributor
lachlan-roberts
left a comment
There was a problem hiding this comment.
The content looks good to me.
Now that we have embedded-guide and distribution-guide do we need to split up the openid information relating to embedded and the distribution into the two separate guides?
Contributor
Author
|
@lachlan-roberts Yeah, but that will be part of a bigger effort across multiple parts of the documentation. For now I just want to get the content in. |
lachlan-roberts
added a commit
that referenced
this pull request
Mar 1, 2020
Co-authored-by: Lachlan <lachlan@webtide.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates documentation based off #4123 for OpenID.