Skip to content

Removes pull-cert-manager-deps test from required tests#711

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
irbekrm:remove_pull_deps
Jun 30, 2022
Merged

Removes pull-cert-manager-deps test from required tests#711
jetstack-bot merged 1 commit intocert-manager:masterfrom
irbekrm:remove_pull_deps

Conversation

@irbekrm
Copy link
Copy Markdown
Contributor

@irbekrm irbekrm commented Jun 30, 2022

As this test is now removed from presubmits

Signed-off-by: irbekrm irbekrm@gmail.com

@irbekrm
Removes pull-cert-manager-deps test from required tests
779d18f 
As this test is now removed

Signed-off-by: irbekrm <irbekrm@gmail.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 30, 2022
@irbekrm irbekrm requested a review from SgtCoDFish June 30, 2022 10:36
@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 30, 2022
SgtCoDFish
SgtCoDFish approved these changes Jun 30, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

I guess this explains why the test was hanging around in PRs! Thanks 😁

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2022
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Jun 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SgtCoDFish SgtCoDFish mentioned this pull request Jun 30, 2022
Closed
30 tasks
@jetstack-bot jetstack-bot merged commit 5423ebb into cert-manager:master Jun 30, 2022
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Jun 30, 2022

@irbekrm: Updated the config configmap in namespace default at cluster default using the following files:

  • key config.yaml using file config/config.yaml
Details

In response to this:

As this test is now removed from presubmits

Signed-off-by: irbekrm irbekrm@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@irbekrm irbekrm deleted the remove_pull_deps branch June 30, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees

@SgtCoDFish SgtCoDFish

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@irbekrm @jetstack-bot @SgtCoDFish