Skip to content

Don't test using bazel on master#710

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
SgtCoDFish:nobazel
Jun 30, 2022
Merged

Don't test using bazel on master#710
jetstack-bot merged 1 commit intocert-manager:masterfrom
SgtCoDFish:nobazel

Conversation

@SgtCoDFish
Copy link
Copy Markdown
Member

@SgtCoDFish SgtCoDFish commented Jun 30, 2022

This leaves only the upgrade test using bazel as of now

@SgtCoDFish SgtCoDFish requested a review from irbekrm June 30, 2022 10:11
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/cert-manager Indicates a PR related to cert-manager approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 30, 2022
@SgtCoDFish
Copy link
Copy Markdown
Member Author

SgtCoDFish commented Jun 30, 2022

/test verify

@SgtCoDFish
Copy link
Copy Markdown
Member Author

SgtCoDFish commented Jun 30, 2022

/test build

@irbekrm
Copy link
Copy Markdown
Contributor

irbekrm commented Jun 30, 2022

@SgtCoDFish also https://github.com/jetstack/testing/blob/master/config/config.yaml#L39-L40

@SgtCoDFish
Copy link
Copy Markdown
Member Author

SgtCoDFish commented Jun 30, 2022

@SgtCoDFish also https://github.com/jetstack/testing/blob/master/config/config.yaml#L39-L40

Thank you, I always forget stuff like this!

@SgtCoDFish
don't test using bazel on master
84c004f 
this leaves only the upgrade test using bazel as of now

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
@SgtCoDFish
Copy link
Copy Markdown
Member Author

SgtCoDFish commented Jun 30, 2022

@irbekrm I also added the make test as required; does it look correct now?

@irbekrm
Copy link
Copy Markdown
Contributor

irbekrm commented Jun 30, 2022

Thanks!

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2022
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Jun 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 0ed77e7 into cert-manager:master Jun 30, 2022
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Jun 30, 2022

@SgtCoDFish: Updated the following 2 configmaps:

  • job-config configmap in namespace default at cluster default using the following files:
    • key cert-manager-presubmits.yaml using file config/jobs/cert-manager/cert-manager/cert-manager-presubmits.yaml
  • config configmap in namespace default at cluster default using the following files:
    • key config.yaml using file config/config.yaml
Details

In response to this:

This leaves only the upgrade test using bazel as of now

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@irbekrm
Copy link
Copy Markdown
Contributor

irbekrm commented Jun 30, 2022

Ahh wait, do we not have to remove pull-cert-manager-deps?

@irbekrm
Copy link
Copy Markdown
Contributor

irbekrm commented Jun 30, 2022

Ahh wait, do we not have to remove pull-cert-manager-deps

I'll do that in a separate PR. Apart from that I think it was right

@SgtCoDFish SgtCoDFish deleted the nobazel branch June 30, 2022 10:34
@SgtCoDFish SgtCoDFish mentioned this pull request Jun 30, 2022
Closed
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@irbekrm irbekrm Awaiting requested review from irbekrm

Assignees

@irbekrm irbekrm

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cert-manager Indicates a PR related to cert-manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SgtCoDFish @irbekrm @jetstack-bot