Don't run unit/integration tests with bazel where we use make#702
Don't run unit/integration tests with bazel where we use make#702jetstack-bot merged 1 commit intocert-manager:masterfrom
Conversation
…make Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
| cpu: 2 | ||
| memory: 4Gi | ||
| cpu: 1 | ||
| memory: 2Gi |
There was a problem hiding this comment.
note: I reduced resource requirements just because the amount of stuff that's gonna get done in these tests is minimal and I feel like we can take back some resources. It's entirely unscientific to just halve the requests here, but we can always change if this proves too small.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakexks, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@SgtCoDFish: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I think we could've made this change a while ago and saved some build time 😅
We run unit and integration tests with make for release-1.8 and master. We don't need to also run them with bazel.
We'll be able to remove the bazel tests entirely when all of our tests are available in make, which shouldn't take long. Still, we can take this win now!