Skip to content

Adds ExperimentalSecretApplySecretTemplateControllerMinKubernetesVTODO to cert-manager feature gate env vars#611

Merged
JoshVanL merged 1 commit intocert-manager:masterfrom
JoshVanL:cert-manager-secret-template-feature-gate
Dec 2, 2021
Merged

Adds ExperimentalSecretApplySecretTemplateControllerMinKubernetesVTODO to cert-manager feature gate env vars#611
JoshVanL merged 1 commit intocert-manager:masterfrom
JoshVanL:cert-manager-secret-template-feature-gate

Conversation

@JoshVanL
Copy link
Copy Markdown
Contributor

@JoshVanL JoshVanL commented Dec 1, 2021

Currently set to true in both feature groups to test which Kubernetes versions work with this feature.

The name currently has vTODO until we find out what is the minimum Kubernetes version this works with.

NONE

@JoshVanL
Adds ExperimentalSecretApplySecretTemplateControllerMinKubernetesVTODO
74fb680 
to cert-manager feature gate env vars

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/cert-manager Indicates a PR related to cert-manager approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 1, 2021
@SgtCoDFish
Copy link
Copy Markdown
Member

SgtCoDFish commented Dec 2, 2021

/lgtm

(as requested in slack!)

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2021
SgtCoDFish
SgtCoDFish approved these changes Dec 2, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different repos needing different approvals makes me sad :(

@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Dec 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JoshVanL JoshVanL merged commit b23a3cf into cert-manager:master Dec 2, 2021
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Dec 2, 2021

@JoshVanL: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key config.yaml using file config/jobs/cert-manager/config.yaml
Details

In response to this:

Currently set to true in both feature groups to test which Kubernetes versions work with this feature.

The name currently has vTODO until we find out what is the minimum Kubernetes version this works with.

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoshVanL JoshVanL mentioned this pull request Dec 2, 2021
Merged
@SgtCoDFish
Copy link
Copy Markdown
Member

SgtCoDFish commented Dec 2, 2021

Ah, unfortunately this blocks e2e tests on every other PR which isn't based off this one because currently an unknown feature gate flag is a critical error.

e.g. The make PR had this failure, which leads to this log file:

2021-12-02T15:52:52.380994138Z stderr F E1202 15:52:52.380441 1 main.go:39] cert-manager "msg"="error while executing" "error"="invalid argument "ExperimentalCertificateSigningRequestControllers=true,ExperimentalGatewayAPISupport=true,ExperimentalSecretApplySecretTemplateControllerMinKubernetesVTODO=true" for "--feature-gates" flag: unrecognized feature gate: ExperimentalSecretApplySecretTemplateControllerMinKubernetesVTODO"

@SgtCoDFish SgtCoDFish mentioned this pull request Dec 2, 2021
Merged
@maelvls
Copy link
Copy Markdown
Member

maelvls commented Dec 3, 2021 •
edited
Loading

@JoshVanL I do not see the settings for this project. Could you disable "require a pull request before merging" (we have that disabled on the cert-manager repository)? Thanks!
screencapture-github-jetstack-cert-manager-settings-branch-protection-rules-1176377-2021-12-03-10_32_11

@JoshVanL
Copy link
Copy Markdown
Contributor Author

JoshVanL commented Dec 3, 2021 •
edited
Loading

@JoshVanL I do not see the settings for this project. Could you disable "require a pull request before merging" (we have that disabled on the cert-manager repository)? Thanks!

@maelvls Could you explain the purpose of doing this?

@JoshVanL JoshVanL mentioned this pull request Dec 3, 2021
Merged
@maelvls
Copy link
Copy Markdown
Member

maelvls commented Dec 4, 2021 •
edited
Loading

@JoshVanL I (wrongly) thought it would solve the disparity in how jetstack-bot behaves with regards to approval between the cert-manager repository and the testing repository. Thinking a second time about it, this issue does not come from the GitHub settings and probably comes from the configuration of jetstack-bot. Where do you think we can fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees

@SgtCoDFish SgtCoDFish

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cert-manager Indicates a PR related to cert-manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JoshVanL @SgtCoDFish @jetstack-bot @maelvls