Skip to content

Add kubebuilder tools in make for integration tests#4753

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
SgtCoDFish:kubebuildertools
Jan 18, 2022
Merged

Add kubebuilder tools in make for integration tests#4753
jetstack-bot merged 1 commit intocert-manager:masterfrom
SgtCoDFish:kubebuildertools

Conversation

@SgtCoDFish
Copy link
Copy Markdown
Member

@SgtCoDFish SgtCoDFish commented Jan 17, 2022

Note that darwin/arm64 has to be special cased currently because of a lack of official support for that platform in upstream etcd and kube-apiserver. We instead install the amd64 versions, which is what we did for bazel.

Testers with M1 macs would be especially valuable for this PR!

/kind feature

NONE

@SgtCoDFish
add kubebuilder tools in make for integration tests
7484128 
Note that darwin/arm64 has to be special cased currently because of a
lack of official support for that platform in upstream etcd and
kube-apiserver. We instead install the amd64 versions, which is what
we did for bazel.

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 17, 2022
@SgtCoDFish SgtCoDFish mentioned this pull request Jan 17, 2022
Closed
30 tasks
@jahrlin
Copy link
Copy Markdown
Contributor

jahrlin commented Jan 17, 2022

/assign

@jahrlin
Copy link
Copy Markdown
Contributor

jahrlin commented Jan 18, 2022 •
edited
Loading

Works on my M1 with Rosetta installed:

❯ make -f make/Makefile integration-test-tools
make/tools.mk:192: Downloading amd64 kubebuilder-tools for integration tests since darwin/arm64 isn't currently packaged. This will require rosetta in order to work
curl -sSfL https://storage.googleapis.com/kubebuilder-tools/kubebuilder-tools-1.22.0-darwin-amd64.tar.gz > bin/scratch/tools/kubebuilder-tools-1.22.0-darwin-arm64.tar.gz
./hack/util/checkhash.sh bin/scratch/tools/kubebuilder-tools-1.22.0-darwin-arm64.tar.gz bb27efb1d2ee43749475293408fc80b923324ab876e5da54e58594bbe2969c42
tar xfO bin/scratch/tools/kubebuilder-tools-1.22.0-darwin-arm64.tar.gz kubebuilder/bin/etcd > bin/tools/etcd && chmod 775 bin/tools/etcd
curl -sSfL https://storage.googleapis.com/kubernetes-release/release/v1.22.1/bin/darwin/arm64/kubectl > bin/scratch/tools/kubectl_1.22.1_darwin_arm64
./hack/util/checkhash.sh bin/scratch/tools/kubectl_1.22.1_darwin_arm64 c81a314ab7f0827a5376f8ffd6d47f913df046275d44c562915a822229819d77
cp bin/scratch/tools/kubectl_1.22.1_darwin_arm64 bin/tools/kubectl
chmod +x bin/tools/kubectl
./hack/util/checkhash.sh bin/scratch/tools/kubebuilder-tools-1.22.0-darwin-arm64.tar.gz bb27efb1d2ee43749475293408fc80b923324ab876e5da54e58594bbe2969c42
tar xfO bin/scratch/tools/kubebuilder-tools-1.22.0-darwin-arm64.tar.gz kubebuilder/bin/kube-apiserver > bin/tools/kube-apiserver && chmod 775 bin/tools/kube-apiserver

/approve
/lgtm
/hold

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2022
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Jan 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jahrlin, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SgtCoDFish
Copy link
Copy Markdown
Member Author

SgtCoDFish commented Jan 18, 2022

@jahrlin interestingly it looks like jetbot hasn't seen your lgtm - there's no lgtm label on the PR, although it found the hold 🤔

could you try /lgtming again?

@jahrlin
Copy link
Copy Markdown
Contributor

jahrlin commented Jan 18, 2022

/lgtm

I edited my comment and added the lgtm after 😇

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2022
@SgtCoDFish
Copy link
Copy Markdown
Member Author

SgtCoDFish commented Jan 18, 2022

/unhold

I edited my comment and added the lgtm after 😇

I swear I've seen that work sometimes but maybe Jetbot can be a bit temperamental 😅

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2022
@jetstack-bot jetstack-bot merged commit 0b686b8 into cert-manager:master Jan 18, 2022
@jetstack-bot jetstack-bot added this to the v1.7 milestone Jan 18, 2022
@SgtCoDFish SgtCoDFish deleted the kubebuildertools branch January 18, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jahrlin jahrlin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.7

Development

Successfully merging this pull request may close these issues.

3 participants

@SgtCoDFish @jahrlin @jetstack-bot