Match upstream boilerplate verification for files w/ go:build#4715
Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom Jan 6, 2022
Merged
Match upstream boilerplate verification for files w/ go:build#4715jetstack-bot merged 1 commit intocert-manager:masterfrom
jetstack-bot merged 1 commit intocert-manager:masterfrom
Conversation
the regex being replaced doesn't match files which only contain go:build although as of go 1.17 (which we require for cert-manager) that's totally valid. this commit updates the regex to match upstream k8s, which is the original source of the boilerplate verification script in any case upstream: https://github.com/kubernetes/kubernetes/blob/47ff335d4c678f8ebe12369055d4b3806d0fb9f4/hack/boilerplate/boilerplate.py#L219-L223 Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
This was referenced Jan 6, 2022
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakexks, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regex being replaced doesn't match files which only contain
//go:buildalthough as of go 1.17 (which we require for cert-manager) that seems totally valid.This commit updates the regex to match upstream k8s, which is the original source of the boilerplate verification script in any case.
See the upstream version of the script for more details
/kind feature