Skip to content

Upgrade ingress-nginx Helm Chart and Docker image#4046

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
wallrj:upgrade-ingress-nginx
May 21, 2021
Merged

Upgrade ingress-nginx Helm Chart and Docker image#4046
jetstack-bot merged 1 commit intocert-manager:masterfrom
wallrj:upgrade-ingress-nginx

Conversation

@wallrj
Copy link
Copy Markdown
Member

@wallrj wallrj commented May 21, 2021

Spun out from #4036

Release note:

NONE

/kind cleanup

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 21, 2021
@wallrj
Copy link
Copy Markdown
Member Author

wallrj commented May 21, 2021

/test pull-cert-manager-bazel
/test pull-cert-manager-e2e-v1-16

Copy link
Copy Markdown
Contributor

@irbekrm irbekrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I wonder if it'd be worth to look into setting up some sort of automation for bumping these deps.

@jetstack-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@irbekrm
Copy link
Copy Markdown
Contributor

irbekrm commented May 21, 2021

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2021
@jetstack-bot jetstack-bot merged commit 9837ccd into cert-manager:master May 21, 2021
@jetstack-bot jetstack-bot added this to the v1.4 milestone May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants