Remove legacy e2e util functions for Issuer creation#3873
Remove legacy e2e util functions for Issuer creation#3873jetstack-bot merged 1 commit intocert-manager:masterfrom
Conversation
70c2acb to
585c6f7
Compare
Use test/util/gen instead Signed-off-by: irbekrm <irbekrm@gmail.com>
585c6f7 to
333f600
Compare
|
/test pull-cert-manager-bazel |
|
Since this is technically a breaking change if anyone imports the deleted functions in, say, a closed-source product which wouldn't appear on pkg.go.dev, would it be worth noting that in the release notes? I agree that the chances of anyone using these functions is really low. In any case if anyone was using the deleted functions they have an easy upgrade path by copying what's been done in this PR. |
wallrj
left a comment
There was a problem hiding this comment.
It looks like a nice cleanup.
Maybe add a release-note documenting that we've removed those public functions and mention the suggested alternative.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irbekrm, wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks @SgtCoDFish , @wallrj ! Agree on release note- I have added that, please take a look. |
|
release notes look good! /lgtm |
This PR removes a bunch of legacy functions for issuer generation from
test/e2e/util/util.goas it partially duplicated the functionality intest/unit/gen/issuer.goand adds some more specific issuer generation functions totest/unit/gen/issuer.go.I hope no-one has been importing these legacy functions - I did not find external imports on
pkg.go.devThis PR was originally part of #3850 which is getting split into multiple PRs.
/kind cleanup
Signed-off-by: irbekrm irbekrm@gmail.com