Skip to content

Add support for the pod PriorityClass field in HTTP01 podTemplate#3112

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
meyskens:add-pod-priority
Jul 30, 2020
Merged

Add support for the pod PriorityClass field in HTTP01 podTemplate#3112
jetstack-bot merged 1 commit intocert-manager:masterfrom
meyskens:add-pod-priority

Conversation

@meyskens
Copy link
Copy Markdown
Contributor

@meyskens meyskens commented Jul 23, 2020 •
edited
Loading

What this PR does / why we need it:
This adds support for the priorityClassName field for HTTP01 solvers.

Which issue this PR fixes:
fixes: #3108

Release note:

Add `priorityClassName` field to `podTemplate` for ACME HTTP01 issuers

/kind feature

@meyskens
Add support for the podPriorityClass field in HTTP01 podTemplate
2130329 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Jul 23, 2020
@jetstack-bot jetstack-bot requested a review from JoshVanL July 23, 2020 08:23
@jetstack-bot jetstack-bot added the area/acme Indicates a PR directly modifies the ACME Issuer code label Jul 23, 2020
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Jul 23, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: meyskens

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code area/api Indicates a PR directly modifies the 'pkg/apis' directory approved Indicates a PR has been approved by an approver from all required OWNERS files. area/deploy Indicates a PR modifies deployment configuration needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 23, 2020
@meyskens meyskens added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 23, 2020
@jetstack-bot jetstack-bot removed the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jul 23, 2020
@james-w
Copy link
Copy Markdown
Contributor

james-w commented Jul 30, 2020

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2020
@jetstack-bot jetstack-bot merged commit 535f991 into cert-manager:master Jul 30, 2020
@jetstack-bot jetstack-bot added this to the v1.0 milestone Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshVanL JoshVanL Awaiting requested review from JoshVanL

Assignees

@james-w james-w

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code area/acme Indicates a PR directly modifies the ACME Issuer code area/api Indicates a PR directly modifies the 'pkg/apis' directory area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.0

Development

Successfully merging this pull request may close these issues.

Add HTTP01 solver pod priority class support

3 participants

@meyskens @jetstack-bot @james-w