Skip to content

Revert "Narrow the cache of xdg directory"#22

Merged
LucilleH merged 1 commit intomainfrom
revert-20-lucille--narrow-cache
Sep 21, 2023
Merged

Revert "Narrow the cache of xdg directory"#22
LucilleH merged 1 commit intomainfrom
revert-20-lucille--narrow-cache

Conversation

@LucilleH
Copy link
Copy Markdown
Contributor

@LucilleH LucilleH commented Sep 21, 2023

Reverts #20

This results in the ~/.cache directory gets created under root instead of runner. Reverting fix this problem.

Verified the fix with #21

@LucilleH LucilleH added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit c1d7077 Sep 21, 2023
@LucilleH LucilleH deleted the revert-20-lucille--narrow-cache branch September 21, 2023 00:04
github-merge-queue bot pushed a commit that referenced this pull request Sep 22, 2023
### What
This PR tries to reduce side effects by:
- Restores the `tar` command to its original state
- Narrow the ~/.cache directory to just nix and devbox

### Why
We are using `chmod u+s "$(command -v tar)"` to setuid on tar (This is
needed because we are caching `/nix/` and other directories outside of
`~`, which is owned by `root`)

This has a problem where it changes the parent directory of
`~/.cache/nix` to be owned by `root` instead of `runner`.

I thought #22
had fixed it, but we ran into similar issues when we use a go cache on
top of the devbox cache.

### Caveat
Cache enabled on self hosted Linux may stop working
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants