Revert "Narrow the cache of xdg directory"#22
Merged
Conversation
This reverts commit 76d8a64.
mikeland73
approved these changes
Sep 21, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 22, 2023
### What This PR tries to reduce side effects by: - Restores the `tar` command to its original state - Narrow the ~/.cache directory to just nix and devbox ### Why We are using `chmod u+s "$(command -v tar)"` to setuid on tar (This is needed because we are caching `/nix/` and other directories outside of `~`, which is owned by `root`) This has a problem where it changes the parent directory of `~/.cache/nix` to be owned by `root` instead of `runner`. I thought #22 had fixed it, but we ran into similar issues when we use a go cache on top of the devbox cache. ### Caveat Cache enabled on self hosted Linux may stop working
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #20
This results in the
~/.cachedirectory gets created underrootinstead ofrunner. Reverting fix this problem.Verified the fix with #21