Rework jerry_parse function.#2282
Merged
zherczeg merged 1 commit intojerryscript-project:masterfrom Apr 17, 2018
Merged
Conversation
Closed
LaszloLango
reviewed
Apr 16, 2018
| typedef enum | ||
| { | ||
| JERRY_PARSE_STRICT_MODE = (1 << 0), /**< enable strict mode */ | ||
| } jerry_parse_opts_t; |
Contributor
There was a problem hiding this comment.
what about this?
typedef enum
{
JERRY_PARSE_EMPTY = 0, /**< no flags */
JERRY_PARSE_STRICT_MODE = (1 << 0), /**< enable strict mode */
} jerry_parse_flag_t;So it will be similar to jerry_init_flag_t.
Member
Author
There was a problem hiding this comment.
I want to phase out the flag term from the project. The option bits are much better description.
Member
Author
There was a problem hiding this comment.
(You can also see that in the snapshot gen/exec flags already landed).
Contributor
There was a problem hiding this comment.
And what about adding JERRY_PARSE_EMPTY or JERRY_PARSE_NO_OPTIONS? We should avoid using of literals in call sites of jerry_parse.
Member
Author
There was a problem hiding this comment.
Good idea. NO_OPTS added. I can rename it to NO_OPTIONS if you want.
Remove jerry_parse_named_resource, merge its arguments to jerry_parse and change is_strict argument to an option list for possible future extensions. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
fe5467d to
a987b5b
Compare
jimmy-huang
pushed a commit
to jimmy-huang/jerryscript
that referenced
this pull request
May 8, 2018
Remove jerry_parse_named_resource, merge its arguments to jerry_parse and change is_strict argument to an option list for possible future extensions. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
Merged
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Nov 25, 2018
Picked from upstream jerryscript-project/jerryscript#2282
3 tasks
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Nov 25, 2018
Picked from upstream jerryscript-project/jerryscript#2282
yorkie
pushed a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Nov 28, 2018
Picked from upstream jerryscript-project/jerryscript#2282
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove jerry_parse_named_resource, merge its arguments to jerry_parse and change is_strict argument to an option list for possible future extensions.