Conversation
fix warning when printing uint128_t
Authored-by: Harun Mustafa <hmusta@users.noreply.github.com>
Support larger alphabets and k via generic kmer_t
Clang warns:
```
util.hpp:127:17: warning: 'static' function 'get_seed_for_hash_function' declared in header file should be declared 'static inline' [-Wunneeded-internal-declaration]
static uint64_t get_seed_for_hash_function(build_configuration const& build_config) {
```
I think this could cause potential issues across translation units and so it's probably best to inline this?
make static function inline in header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring into
masterthe modification made intodev: support for larger k, generic alphabets, and support for Cuttlefish inputs, compatibility for Piscem.