Redeclare JSch dependency to the jsch-plugin#7
Redeclare JSch dependency to the jsch-plugin#7zregvart wants to merge 1 commit intojenkinsci:masterfrom
Conversation
There was a problem hiding this comment.
Hi Jessie, thanks for the comment. As I understand, the ssh-credential plugin can be used with both Jsch and Trilead SSH implementations, and it's up to the plugin to choose which one to use and redeclare it as non-optional.
There was a problem hiding this comment.
This plugin does not do anything with Trilead (that I can see). It does offer authenticators for use with JSch which other plugins may call as an API. Since the proposed jsch-plugin offers no UI or any other extensions, there is no reason (that I know of) not to have it installed, so there is no reason to complicate things by making this dependency optional. But @stephenc may have some motivation I am not aware of.
There was a problem hiding this comment.
@jglick take your fight against optional elsewhere. I'm fine with this being optional ;-)
|
Have you cut a release of jsch plugin... also I would advise adding a .0 to the version number of jsch that you package in case you identify an issue with your plugin and need a new release that includes the same version of jsch... e.g. see mapdb plugin where the version number is composed of the mapdb version number with another segment added. |
|
@stephenc thanks for chiming in, I pushed the release somewhat after creating the pull request (that's why the build failed) and now I'm too lazy to push another. I guess I can always add a fourth version number to the jsch-plugin if need be (or make it non semver like 0.1.42-1). @jglick the ssh-credential plugin indeed uses trilead, so I guess it's ok to keep jsch optional -- on par with trilead. Might want to consider creating a dependency plugin for trilead, in the manner of jsch-plugin, to prevent class[loading|casting] issues in other plugins. |
|
The Trilead dependency is getting sucked in via |
|
In an ideal world you might invert the dependency and move the jack If we do that for trilead's then they would be nicely symmetry On Thursday, 9 October 2014, Jesse Glick notifications@github.com wrote:
Sent from my phone |
|
superceded by #19 |
So I've created the ssh-plugin and forked it under the jenkinsci/jsch-plugin, this changes the JSch dependency to that plugin. I need this for the ssh-credentials support in ssh-plugin.