Move built-in JSch implmentations to jsch-plugin#19
Move built-in JSch implmentations to jsch-plugin#19bpedman wants to merge 2 commits intojenkinsci:masterfrom
Conversation
Impementation of the SSHAuthenticatorFactorys for JSch have moved to the jsch-plugin for a cleaner dependency structure.
|
👍 on the principle |
| </pluginRepositories> | ||
|
|
||
| <dependencies> | ||
| <!-- regular dependencies --> |
There was a problem hiding this comment.
we need to bump the major version number for this change
|
👎 on merging as is... to have this mergable, include the major version bump in the pom.xml |
Required since the JSch implementation has moved and may break existing consumers.
|
OK, I'm not merging yet as we cannot cut a release without coordinating with releases of https://github.com/jenkinsci/jsch-plugin and https://github.com/jenkinsci/ssh-plugin which will need to have their dependency changes coordinated (ssh-plugin is the only user of the api that we are removing, so it will need a dependency change and bump so that it depends on the jsch-plugin and the newer ssh-credentials plugin). Let's get those ducks in a row and have the maintainers on board for the coordinated releases (Such a pity there is no staging support in the Jenkins Maven Repo... that would make coordinated releases easier) |
|
👍 on these changes though... just we cannot merge and release yet |
|
Please let us get this released. I do not think it is even incompatible: if you just install def f = ExtensionList.lookup(com.cloudbees.jenkins.plugins.sshcredentials.SSHAuthenticatorFactory)[0];
println(f);
f.getClass().getClassLoader().loadClass('com.jcraft.jsch.Session')→ In other words, the implementation in this plugin could never have worked to begin with. |
|
Yes, this should be moved forward - to delete JSch authenticators (eg. JSchSSHPasswordAuthenticator) from ssh-credentials-plugin and cut a major release of ssh-credentials-plugin. |
|
My suggestion would be to just deprecate the current implementation (and inherit classes?) and then to spin the release without a major version bump. It would be safer for plugin dependencies |
Nope, it would cause a cyclic dependency |
|
done with #152 |
See jenkinsci/jsch-plugin#1 for justification on this change. Basically this moves the implementation specific SSHAuthenticatorFactory extensions to another plugin.
I am not sure if this requires a major version bump or some notice of backwards incompatibility. However, seeing as both I and @zregvart had the same issues, I wonder if using the SSHAuthenticator from another plugin every actually worked at all.