Skip to content

Avoid NPE when StepContext has no Launcher#134

Merged
jglick merged 1 commit intojenkinsci:masterfrom
jglick:Launcher-NPE
Nov 1, 2023
Merged

Avoid NPE when StepContext has no Launcher#134
jglick merged 1 commit intojenkinsci:masterfrom
jglick:Launcher-NPE

Conversation

@jglick
Copy link
Member

@jglick jglick commented Oct 30, 2023

Observed in a build log when a K8s agent had been killed (137):

java.lang.NullPointerException
	at com.cloudbees.jenkins.plugins.sshagent.exec.ExecRemoteAgent.stop(ExecRemoteAgent.java:128)
	at com.cloudbees.jenkins.plugins.sshagent.SSHAgentStepExecution.cleanUp(SSHAgentStepExecution.java:200)
	at com.cloudbees.jenkins.plugins.sshagent.SSHAgentStepExecution.access$000(SSHAgentStepExecution.java:25)
	at com.cloudbees.jenkins.plugins.sshagent.SSHAgentStepExecution$Callback.finished(SSHAgentStepExecution.java:108)
	at org.jenkinsci.plugins.workflow.steps.BodyExecutionCallback$TailCall.onFailure(BodyExecutionCallback.java:128)
	at …

@jglick jglick requested a review from a team as a code owner October 30, 2023 18:22
@jglick jglick added the bug label Oct 30, 2023
@jglick jglick merged commit daac4f2 into jenkinsci:master Nov 1, 2023
@jglick jglick deleted the Launcher-NPE branch November 1, 2023 11:31
jglick added a commit to jglick/ssh-agent-plugin that referenced this pull request Jul 30, 2024
@jglick
Defensive null check as in jenkinsci#134
17ba8bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jglick