Merge JSch auth classes and bump dependencies#2
Merge JSch auth classes and bump dependencies#2ljader merged 3 commits intojenkinsci:masterfrom ljader:master
Conversation
Move the implementation of the JSch SSHAuthenticatorFactory from the ssh-credential plugin to this plugin. This enables other plugins to depend on this plugin which has JSch on its classpath. Using the ssh- credential plugin's SSHAuthenticator class caused problems in some cases because the JSch library was not available on the classpath. This provides a cleaner implementation of the SSHAuthenticatorFactory extension point. Other libraries may do the same thing by providing their own plugin which registers SSHAuthenticatorFactory implementations. This also bumps the version of JSch used, mainly because there are newer things in this version that some users may need access to. This also sets the version scheme to <jsch-version>.<package-revision> so that the primary version can be based on the JSch version used but allow us to rev the version in case there are other implementation or package changes.
The JSch 0.1.54 fixes CVS-2016-5725 ssh-credentials was set to 1.12, since JSch auth classes has been moved to different package, so they will be treated like separate JSch auth 'techniques'
oleg-nenashev
left a comment
There was a problem hiding this comment.
The code itself looks good, but I'm not sure if it is a full copy-paste from somewhere. If yes, maybe there is a better way.
CC @stephenc and @jenkinsci/code-reviewers , who may have more context
|
|
||
| /** | ||
| * @author stephenc | ||
| * @since 25/10/2012 15:14 |
There was a problem hiding this comment.
🐜 Wrong Javadoc. At least since if you copy-pasted the code from somewhere.
CC @stephenc
|
|
||
| /** | ||
| * @author stephenc | ||
| * @since 25/10/2012 13:57 |
|
|
||
| /** | ||
| * @author stephenc | ||
| * @since 25/10/2012 14:49 |
The original code for 3 files was copied from https://github.com/jenkinsci/ssh-credentials-plugin/ from tree 121df4268f7e31617003b2d2a6e6097741536a7f (ssh-credentials-1.12)
|
I've provided a PR context and fixed Javadoc since annotations to use versions. /CC @jenkinsci/code-reviewers @oleg-nenashev @stephenc |
|
Ping for review |
|
@zregvart Are you still maintaining this plugin? |
|
@daniel-beck or @oleg-nenashev , since there is no answer from @zregvart , can you give me the push access for this plugin? |
This PR is a first step to release new version of the plugin.
The context:
The intent is to move built-in JSch implmentations from ssh-credentials-plugin to jsch-plugin, to isolate JSch as a dependency plugin and prevent ClassNotFoundException, triggered currently when depending on ssh-credentials-plugin
1st reference - jenkinsci/ssh-credentials-plugin#19
2nd reference - #1
The release plan
Purpose of this PR
Why this PR and not #1 ? - this PR doesn't rely on unreleased 2.x version of ssh-credentials-plugin, so it didn't need coordinated release between plugins - it's easier to release plugin-by-plugin.
It's easier because JSch auth classes has been moved to different package in jsch-plugin than in ssh-credentials-plugin, so they will be treated like separate JSch auth 'techniques' - there is no need for coordinate release.
The duplication will be removed by Step3 of the plan above.