Switch Note.id from Integer to Long #1706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitLab has changed the data type of the Note id field from int to bigint. Fixes jenkinsci#1705 jenkinsci#1705 (comment) describes the issue in more detail.
Contributor
Author
|
The incrementals link is not provided by the ci.jenkins.io job because the branch is out-of-date. Here is a zip file of the plugin built on my computer. |
Contributor
Author
|
@krisstern this is ready for review based on the positive report from #1705 (comment) as reported by @simonefranconetti |
Member
|
Let me cut a new release for this now |
MarkEWaite
added a commit
that referenced
this pull request
Oct 11, 2024
* Switch Note.id from Integer to Long GitLab has changed the data type of the Note id field from int to bigint. Fixes #1705 #1705 (comment) describes the issue in more detail. * NoteObjectAttributes.id needs to be Long also --------- Co-authored-by: Kris Stern <krisstern@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch Note.id from Integer to Long
GitLab has changed the data type of the Note id field from int to bigint.
Fixes #1705
#1705 (comment) describes the issue in more detail.
Testing done
Automated testing only. Needs multiple affected users to report their test results with their installations before this can be moved from draft.
Submitter checklist