[JENKINS-48437] Use new docker-commons API and pass the Run to retrieve the token#168
Merged
dwnusbaum merged 9 commits intojenkinsci:masterfrom Apr 2, 2019
Merged
Conversation
Dohbedoh
approved these changes
Apr 2, 2019
Member
Author
|
Updated to docker-commons 1.14. Build is green on Linux, but Windows builds look like they'll be backed up for hours so I am going to go ahead and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See JENKINS-48437. Subsumes #141 to pick up jenkinsci/docker-commons-plugin#74.
Expands on the existing tests to show that
Credentials.USE_ITEM(Job.CONFIGURE) is the key permission required for the new APIs to be an improvement.Effective diff from #141 is Dohbedoh/docker-workflow-plugin@JENKINS-48437...dwnusbaum:JENKINS-48437