[JENKINS-48437] Add new APIs to retrieve Docker credentials for a Run#74
Merged
dwnusbaum merged 14 commits intojenkinsci:masterfrom Apr 2, 2019
Merged
[JENKINS-48437] Add new APIs to retrieve Docker credentials for a Run#74dwnusbaum merged 14 commits intojenkinsci:masterfrom
dwnusbaum merged 14 commits intojenkinsci:masterfrom
Conversation
Member
You can also use this link for review though GitHub does not let you use references in these URLs, alas. |
jglick
approved these changes
Apr 1, 2019
Member
jglick
left a comment
There was a problem hiding this comment.
Do not know of anything wrong here, but do not understand it well enough to really approve.
src/test/java/org/jenkinsci/plugins/docker/commons/credentials/DockerRegistryEndpointTest.java
Outdated
Show resolved
Hide resolved
Dohbedoh
approved these changes
Apr 1, 2019
Contributor
Dohbedoh
left a comment
There was a problem hiding this comment.
Right. I missed that corner case with Credentilas.USE_ITEM.
thanks @dwnusbaum! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See JENKINS-48437. This subsumes #68 from @Dohbedoh with some tweaks based on my review comments there.
Effective diff from #68 is: Dohbedoh/docker-commons-plugin@JENKINS-48437...dwnusbaum:JENKINS-48437.