Fixes invalid context expectation in test#287
Merged
jglick merged 1 commit intojenkinsci:masterfrom Jan 19, 2024
Merged
Conversation
timja
approved these changes
Jan 19, 2024
jglick
approved these changes
Jan 19, 2024
Member
jglick
left a comment
There was a problem hiding this comment.
Better still to update
to the new constructor. I can do that as a follow-up though.| <dependency> | ||
| <groupId>org.jenkins-ci.plugins.workflow</groupId> | ||
| <artifactId>workflow-step-api</artifactId> | ||
| <version>655.v6e098b_87b_84f</version> <!-- TODO: Removes once the plugin is updated in the BOM --> |
Member
There was a problem hiding this comment.
FWIW I have adopted the convention of putting overrides like this into dependencyManagement, mainly so that they are textually right next to the bom-* dep and thus apparent when evaluating Dependabot bumps that would allow the override to be deleted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
workflow-step-apiplugin changed the wording on the invalid context error. It has to be updated here as well.cc @jglick
Testing done
Running the test with only the pom update and then updated the text string expectation.
This is a follow of jenkinsci/workflow-step-api-plugin#143 and coming from jenkinsci/bom#2846