Revert "Bump org.jenkins-ci.plugins.workflow:workflow-step-api in /bo…#2846
Merged
Revert "Bump org.jenkins-ci.plugins.workflow:workflow-step-api in /bo…#2846
Conversation
basil
approved these changes
Jan 19, 2024
Member
|
If jenkinsci/credentials-binding-plugin#287 isn't merged and released in a short timeframe, please file a BOM issue to track the removal of this workaround. (No need for the formality if the fix is imminent, but want to keep us from losing track if the fix takes longer.) |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…m-weekly (#2845)"
This reverts commit 6b58cd0.
Testing done
Running local-test script locally with
PLUGINS=credentials-binding.This because I detected a problem on the release preparation work. Doing a bisect showed that the problem was the version bump of
workflow-step-api. Additional research showed that the problem came from jenkinsci/workflow-step-api-plugin#143.Initial error report can be seen here: https://ci.jenkins.io/job/Tools/job/bom/job/master/2425/pipeline-console/
cc @jglick
The problem can be reproduced outside of the BOM by running
mvn clean verify -Dtest=org.jenkinsci.plugins.credentialsbinding.impl.BindingStepTest#widerRequiredContextoncredentials-binding. The pull request onworkflow-step-apichanged the wording of the context error but that was not updated in thecredentials-bindingtest.