Skip to content
This repository was archived by the owner on Jun 2, 2025. It is now read-only.

Fix type error with allocated that caused incorrect printing on 32bit #2600

Merged
interwq merged 1 commit into from
Apr 9, 2024
Merged

Fix type error with allocated that caused incorrect printing on 32bit #2600

interwq merged 1 commit into from
Apr 9, 2024

Conversation

@sundb
Copy link
Contributor

@sundb sundb commented Jan 29, 2024

accidentally saw this issue in our 32-bit test CI(https://github.com/redis/redis/actions/runs/7689292345/job/20951532396).

bins:           size ind    allocated      nmalloc (#/sec)      ndalloc (#/sec)    nrequests   (#/sec)  nshards      curregs     curslabs  nonfull_slabs regs pgs   util       nfills (#/sec)     nflushes (#/sec)       nslabs     nreslabs (#/sec)      n_lock_ops (#/sec)       n_waiting (#/sec)      n_spin_acq (#/sec)  n_owner_switch (#/sec)   total_wait_ns   (#/sec)     max_wait_ns  max_n_thds
                   8   018426612771719224472        51166     465        50251     456      2033836     18489        1          915            2              0  512   1  0.893         2113      19          564       5          100            1       0            6017      54               0       0               0       0              70       0               0         0               0           0
                  16   118426612771722053280      2169744   19724      1992486   18113     11267673    102433        1       177258          987            364  256   1  0.701        26604     241        15681     142         6597         7711      70        78313578  711941               0       0               0       0          889506    8086               0         0               0           0
                  24   218426612771719227136          607       5          191       1      4068099     36982        1          416            1              0  512   3  0.812          113       1          102       0            1            0       0            3416      31               0       0               0       0               2       0               0         0               0           0

@sundb sundb changed the title Fixed type error with allocated that caused incorrect printing on 32bit Fix type error with allocated that caused incorrect printing on 32bit Jan 30, 2024
enjoy-binbin added a commit to enjoy-binbin/redis that referenced this pull request Mar 19, 2024
@enjoy-binbin
see jemalloc/jemalloc#2600, temporarily, run the test
f63b689
enjoy-binbin added a commit to enjoy-binbin/redis that referenced this pull request Mar 19, 2024
@enjoy-binbin
Revert "see jemalloc/jemalloc#2600, temporarily, run the test"
1c46c1d 
This reverts commit f63b689.
@interwq interwq merged commit 630434b into jemalloc:dev Apr 9, 2024
@interwq
Copy link
Contributor

interwq commented Apr 9, 2024

Thanks for the patch @sundb !

@sundb sundb deleted the stats_allocated_32bit branch April 10, 2024 01:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sundb @interwq