Merged
Conversation
Contributor
Author
|
Since OSSpinLock is deprecated, also Jason mentioned that pthread_mutex may cause reentrancy problems on Mac. Let's remove OSSpinLock but still prefer os_unfair_lock on Mac. |
djwatson
approved these changes
Nov 14, 2018
nicktrav
added a commit
to nicktrav/cockroach
that referenced
this pull request
Dec 8, 2022
Update jemalloc to point to the upstream 5.3.0 release, hosted on our internal fork. This removes two custom patches that are no longer required: - Fix deadlock in multithreaded fork in OS X - fix upstreamed in jemalloc/jemalloc#954. - Fix JEMALLOC_MUTEX_INIT_CB to only be set if OSS_PINLOCK is false - spinlock support was removed upstream in jemalloc/jemalloc#1367 Touches cockroachdb#83289. Epic: CRDB-20293. Release note: None.
nicktrav
added a commit
to nicktrav/cockroach
that referenced
this pull request
Jan 5, 2023
Update jemalloc to point to the upstream 5.3.0 release, hosted on our internal fork. This removes two custom patches that are no longer required: - Fix deadlock in multithreaded fork in OS X - fix upstreamed in jemalloc/jemalloc#954. - Fix JEMALLOC_MUTEX_INIT_CB to only be set if OSS_PINLOCK is false - spinlock support was removed upstream in jemalloc/jemalloc#1367 Touches cockroachdb#83289. Epic: CRDB-20293. Release note: None.
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Jan 6, 2023
93045: c-deps: update jemalloc to 5.3.0 r=rickystewart a=nicktrav Update jemalloc to point to the upstream 5.3.0 release, hosted on our internal fork. This removes two custom patches that are no longer required: - Fix deadlock in multithreaded fork in OS X - fix upstreamed in jemalloc/jemalloc#954. - Fix JEMALLOC_MUTEX_INIT_CB to only be set if OSS_PINLOCK is false - spinlock support was removed upstream in jemalloc/jemalloc#1367 Touches #83289. Closes #17013. Closes #83289. Epic: CRDB-20293. Release note (performance improvement): The memory allocator, `jemalloc` was updated to the latest available upstream version, 5.3.0, from 4.5.0. This update pulls in a number of upstream improvements, including reduced memory fragmentation for memory allocated outside of the Go runtime (i.e. the Pebble block and table caches), resulting in better memory utilization. Co-authored-by: Nick Travers <travers@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OSSpinLock is deprecated and we have os_unfair_lock support for Mac.
This solves #843