550 drupal 7 does not import author name email#551
Merged
jekyllbot merged 2 commits intojekyll:masterfrom Jan 18, 2025
Merged
Conversation
Member
|
LGTM, and thank you for testing! @jekyllbot: merge +minor |
jekyllbot
added a commit
that referenced
this pull request
Jan 18, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 18, 2025
Lyndsey Padget: 550 drupal 7 does not import author name email (#551) Merge pull request 551
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #550.
While the issue was written up for Drupal 7, I realized that the drupal7 and drupal8 importers share a common file. I believe this approach should work for Drupal 8 as well, and it's reasonable to assume that users would want author name and email supported in both versions.
As mentioned in the issue description, I could use some guidance on how to test this. Or, provide a build and I'll be the guinea pig! (For Drupal 7 at least.)