Escape non ascii-characters while image downlading from wordpress#531
Merged
jekyllbot merged 2 commits intojekyll:masterfrom Dec 5, 2023
Merged
Escape non ascii-characters while image downlading from wordpress#531jekyllbot merged 2 commits intojekyll:masterfrom
jekyllbot merged 2 commits intojekyll:masterfrom
Conversation
Member
|
Thanks for contributing! ❤️ Could you address the comment from the code style check action and update your PR? I'll be happy to merge it after that. |
parkr
approved these changes
Dec 4, 2023
Member
parkr
left a comment
There was a problem hiding this comment.
It would be nice to see a test but I know this project doesn't have great test coverage so approving anyway.
Contributor
Author
Member
|
@jekyllbot: merge +fix |
jekyllbot
added a commit
that referenced
this pull request
Dec 5, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
Ahmet ÖZER: Escape non ascii-characters while image downlading from wordpress (#531) Merge pull request 531
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While importing one of the Turkish websites, I noticed ruby HTTP library was not able to download because of the non-ASCII characters.
So I used escape while download process.
An example command
ruby -r rubygems -e 'require "jekyll-import";JekyllImport::Importers::WordpressDotCom.run({"source" => "wordpress.xml","no_fetch_images" => false, "assets_folder" => "assets" })'