Skip to content

Clean up code to make Rubocop happy#441

Merged
jekyllbot merged 4 commits intomasterfrom
fix-rubocop-failures
Apr 24, 2021
Merged

Clean up code to make Rubocop happy#441
jekyllbot merged 4 commits intomasterfrom
fix-rubocop-failures

Conversation

@parkr
Copy link
Member

@parkr parkr commented Apr 24, 2021

lib/jekyll-import/importers/drupal6.rb:52:9: C: Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||. (https://rubystyle.guide#if-as-a-modifier)
        if sql_post_data[:alias]
        ^^
lib/jekyll-import/importers/rss.rb:32:7: C: Metrics/CyclomaticComplexity: Cyclomatic complexity for process is too high. [7/6]
      def self.process(options) ...
      ^^^^^^^^^^^^^^^^^^^^^^^^^
lib/jekyll-import/importers/rss.rb:44:9: C: Metrics/BlockLength: Block has too many lines. [32/25]
        rss.items.each do |item| ...
        ^^^^^^^^^^^^^^^^^^^^^^^^
lib/jekyll-import/importers/s9y_database.rb:371:15: C: Style/StderrPuts: Use warn instead of STDERR.puts to allow such output to be disabled. (https://rubystyle.guide#warn)
              STDERR.puts "Unrecognized media block: #{imgcaption}"
              ^^^^^^^^^^^

@parkr
Copy link
Member Author

parkr commented Apr 24, 2021

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit c355fc1 into master Apr 24, 2021
@jekyllbot jekyllbot deleted the fix-rubocop-failures branch April 24, 2021 20:13
jekyllbot added a commit that referenced this pull request Apr 24, 2021
@jekyll jekyll locked and limited conversation to collaborators Apr 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants