Check whether option["tag"] is null or empty value#411
Merged
jekyllbot merged 2 commits intojekyll:masterfrom May 2, 2019
Merged
Check whether option["tag"] is null or empty value#411jekyllbot merged 2 commits intojekyll:masterfrom
jekyllbot merged 2 commits intojekyll:masterfrom
Conversation
mattr-
requested changes
Apr 30, 2019
Member
mattr-
left a comment
There was a problem hiding this comment.
Good catch! What do you think about using #fetch here instead?
mattr-
approved these changes
Apr 30, 2019
Member
|
@jekyllbot: merge +fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
optionis expected to be a Hash. Thereforeoption.to_sis never going to be empty since even{}.to_sequals"{}". Tracing the git history of the line of code shows that this is probably an error during merge-resolution.I'm opting to use the more verbose
options["tag"].nil? || options["tag"].empty?instead ofoptions["tag"].to_s.empty?since this conditional is inside an#eachblock. Using the latter format would result in unnecessary allocations of""whenoptions["tag"] == nil