Closed
Conversation
added 5 commits
July 2, 2013 10:34
Member
|
LGTM, I'll cherry-pick your commit again :) |
Member
|
Actually maybe we should fall back to the old method if there is no |
Member
|
@georgeanderson What do you think about #40? |
parkr
added a commit
that referenced
this pull request
Jul 8, 2013
Contributor
Author
|
@parkr Sounds good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom slug code is error prone and can create wrong entries like:
2011-12-03-ruby-on-rails---easy-setup-on-ubuntu.md
Where the correct is:
2011-12-03-ruby-on-rails-easy-setup-on-ubuntu.md
It also avoids huge photo captions to be used as the file name like in my case below:
2013-07-04-george-turned-2-today-thats-an-automatic-post-from-tumblr-i-will-also-use-to-inform-the-belowim-on-my-way-out-tumblr-going-into-jekyll-direction-migration-is-in-progress-and-it-should-be-completed-soon.md
With my change the above becomes:
2013-07-04-george-turned-2-today-thats-an-automatic-post.md
@parkr: Sorry I was not able to isolate my commits again. I did something wrong with my feature branch and hope to get it right in the next time.
Thanks,
George.