Refactor Blogger importer with guard clauses#388
Merged
jekyllbot merged 2 commits intojekyll:masterfrom Apr 24, 2021
Merged
Conversation
DirtyF
approved these changes
Nov 23, 2020
parkr
approved these changes
Apr 24, 2021
Member
parkr
left a comment
There was a problem hiding this comment.
@ashmaroli This looks great! Unfortunately there are some issues with merge conflicts (I merged another PR of yours into this importer). Want to fix those up and merge +minor?
parkr
reviewed
Apr 24, 2021
Member
|
@jekyllbot: merge +dev |
jekyllbot
added a commit
that referenced
this pull request
Apr 24, 2021
ashmaroli
added a commit
that referenced
this pull request
Aug 26, 2021
This reverts commit 9fdce63.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically reducing number of lines and code indentation due to nested conditionals