Skip to content

Refactor Tumblr Importer#362

Merged
jekyllbot merged 6 commits intojekyll:masterfrom
ashmaroli:refactor-tumblr-importer
Oct 17, 2018
Merged

Refactor Tumblr Importer#362
jekyllbot merged 6 commits intojekyll:masterfrom
ashmaroli:refactor-tumblr-importer

Conversation

@ashmaroli
Copy link
Member

@ashmaroli ashmaroli commented Oct 12, 2018 •
edited
Loading

  • Simplify conditionals with guard clauses
  • Improve readability with whitespace
  • Follow DRY principle
  • Parallel assignments and String interpolations
  • Freeze string literals to reduce allocations

@ashmaroli ashmaroli changed the title WIP: Refactor Tumblr Importer Refactor Tumblr Importer Oct 12, 2018
@ashmaroli ashmaroli requested a review from a team October 12, 2018 18:17
DirtyF
DirtyF approved these changes Oct 12, 2018
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import tested successfully.

@DirtyF
Copy link
Member

DirtyF commented Oct 17, 2018

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit 5a19db0 into jekyll:master Oct 17, 2018
jekyllbot added a commit that referenced this pull request Oct 17, 2018
@jekyllbot
Update history to reflect merge of #362 [ci skip]
f20da35
@DirtyF DirtyF removed the bug label Oct 17, 2018
@ashmaroli ashmaroli deleted the refactor-tumblr-importer branch October 17, 2018 16:10
@jekyll jekyll locked and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DirtyF DirtyF DirtyF approved these changes

Assignees

No one assigned

Labels

fix frozen-due-to-age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ashmaroli @DirtyF @jekyllbot