Skip to content

Replace uninitialized constant with alternative#358

Merged
jekyllbot merged 1 commit intojekyll:masterfrom
ashmaroli:replace-uninitialized-constant
Oct 11, 2018
Merged

Replace uninitialized constant with alternative#358
jekyllbot merged 1 commit intojekyll:masterfrom
ashmaroli:replace-uninitialized-constant

Conversation

@ashmaroli
Copy link
Member

$INPUT_RECORD_SEPARATOR requires loading "english" from Ruby stdlib to initialize it.
So, its better remove the warning from Ruby by using the pre-initialized alternative $/ especially since Rubocop does not complain about it now..

@ashmaroli ashmaroli requested a review from DirtyF October 11, 2018 13:22
@DirtyF
Copy link
Member

DirtyF commented Oct 11, 2018

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 679aef5 into jekyll:master Oct 11, 2018
jekyllbot added a commit that referenced this pull request Oct 11, 2018
@ashmaroli ashmaroli deleted the replace-uninitialized-constant branch October 11, 2018 15:33
@jekyll jekyll locked and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants