Updating Ruby and Jekyll versions for testing#290
Conversation
Nokogiri no longer supports Ruby 1.9.3 it seems, causing tests to fail.
.travis.yml
Outdated
| @@ -1,6 +1,5 @@ | |||
| language: ruby | |||
| rvm: | |||
| - 2.3 | |||
There was a problem hiding this comment.
@pathawks looks like 2.3.1 is supported - https://travis-ci.org/jekyll/jekyll-import/jobs/192211050
.travis.yml
Outdated
| - JEKYLL_VERSION=3.3 | ||
| - JEKYLL_VERSION=3.0 | ||
| - JEKYLL_VERSION=2.5 | ||
| - JEKYLL_VERSION=2.0 |
There was a problem hiding this comment.
Is there a reason to support Jekyll 2.0?
You could probably even drop Jekyll 2.5 at this point.
There was a problem hiding this comment.
I was trying to find what Jekyll versions were being supported. I guess now 3.x is up to 3.3, the 2.x branch is probably dead? Should be tested for legacy users I suppose...
Does 2.5 uses the 2.5.3 release?
.travis.yml
Outdated
| global: | ||
| - NOKOGIRI_USE_SYSTEM_LIBRARIES=true | ||
| matrix: | ||
| - JEKYLL_VERSION=3.3 |
There was a problem hiding this comment.
I think Bundler actually resolves 3.0 to the latest 3.x version, as can be seen here
.travis.yml
Outdated
| - JEKYLL_VERSION=3.3 | ||
| - JEKYLL_VERSION=3.0 | ||
| - JEKYLL_VERSION=2.5 | ||
| - JEKYLL_VERSION=2.5.3 |
There was a problem hiding this comment.
Same as above, but if we want to be extra explicit, I don't think there's any harm 👍
There was a problem hiding this comment.
Ahh cool - I think using the lastest within that branch makes more sense. Adds maintenance headaches otherwise.
2.5 will also resolve to 2.5.3 too.
|
@pathawks thanks for the quick reviews - would be good to get this in so other PR's can be properly tested :) |
|
@jekyllbot: merge +dev |
Nokogiri no longer supports Ruby 1.9.3 it seems, causing tests to fail.
Given 1.9.3 is EOL, IMHO it should not longer be supported by this Gem.
Also, 2.0 is EOL so there is no point adding that. And it seems 2.3 and 2.4 are not available yet either.