Fix for misnamed Joomla3 module in docs#271
Merged
jekyllbot merged 2 commits intojekyll:masterfrom Sep 18, 2016
Merged
Conversation
Fixes issue jekyll#270
Member
|
Looks like we need to drop Ruby 1.9 from the test suite. |
Made it more clear what the category is supposed to be about, as it looked like a string while it really is not. If one was to put the number between quotes, one would get "comparison of String with 0 failed (ArgumentError)"
Contributor
Author
|
Added another small improvement: the category field is numerical, not a string. |
| and `host` defaults to `"localhost"`. | ||
|
|
||
| If the `category` field is not filled, all articles will be imported, except the ones that are | ||
| If the `category` numerical field is not filled, all articles will be imported, except the ones that are |
Member
There was a problem hiding this comment.
Is the category always numerical?
Member
|
Thanks! One question above. |
Contributor
Author
|
In the current implementation of the importer, yes. Joomla stores categories as numbers; there is also a table that maps those numbers into human-readable names. It would be nice to make use of that, but it would make the tool quite a bit more complex. |
parkr
approved these changes
Sep 18, 2016
Member
parkr
left a comment
There was a problem hiding this comment.
Category as integer value sounds good to me, thank you!
Member
|
@jekyllbot: merge +site |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #270