Tumblr: Update range of JSON readlines to extract JSON from JS (Tumblr may have changed structure of JSON)#243
Merged
jekyllbot merged 1 commit intojekyll:masterfrom Apr 27, 2016
Merged
Conversation
Member
|
Thanks for the PR, @karenjho! What do you think about searching the string for the index of the first |
Member
|
@jekyllbot: merge +bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tumblr might have changed the structure of its JSON recently. The jekyll Tumblr importer is currently stripping out the ending curly brace (results in an "unexpected token error" with JSON parser).