Update wordpressdotcom.rb to use its method parameter correctly.#24
Merged
parkr merged 2 commits intojekyll:masterfrom May 15, 2013
Merged
Update wordpressdotcom.rb to use its method parameter correctly.#24parkr merged 2 commits intojekyll:masterfrom
parkr merged 2 commits intojekyll:masterfrom
Conversation
When invoked from the command line using `jekyll import wordpressdotcom -s $FILENAME`, the `filename` argument being passed in to WordpressDotCom::process() is not a simple string. It is instead a Hash, and as such the method's dying on line 15. This patch fixes the error.
Member
|
Please update the fallback in the method definition, too! |
My previous commit fixed a bug in how the method handles the `filename` argument, but introduced a new one in that I hadn't updated the method's default `filename` value to _also_ be a hash. This commit fixes that.
Contributor
Author
|
Good catch, thanks for pointing it out. I think I've got it this time. |
|
Fixes #23 |
parkr
added a commit
that referenced
this pull request
May 15, 2013
Update wordpressdotcom.rb to use its method parameter correctly.
parkr
added a commit
that referenced
this pull request
May 15, 2013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When invoked from the command line using
jekyll import wordpressdotcom -s $FILENAME, thefilenameargument being passed in to WordpressDotCom::process() is not a simple string. It is instead a Hash, and as such the method's dying on line 15. This patch fixes the error.