Skip to content

Fix missing glob matching pattern support description in the documentation of the include and exclude configuration options#9697

Merged
jekyllbot merged 2 commits intojekyll:masterfrom
brlin-tw:patch/improve-exclude-include-documentation
Oct 20, 2024
Merged

Fix missing glob matching pattern support description in the documentation of the include and exclude configuration options#9697
jekyllbot merged 2 commits intojekyll:masterfrom
brlin-tw:patch/improve-exclude-include-documentation

Conversation

@brlin-tw
Copy link
Copy Markdown
Contributor

@brlin-tw brlin-tw commented Oct 11, 2024

This is a 🔦 documentation change.

Summary

This pull request adds a missing glob pattern support description in the documentation of the include and exclude site configuration options.

It appears that Regexp is also supported, but I am unable to use it at my end so it will not be addressed in this PR.

Context

Fixes #9696

…ation of the `include` and `exclude` configuration options

Fixes jekyll#9696.

Signed-off-by: 林博仁(Buo-ren Lin) <buo.ren.lin@gmail.com>
@brlin-tw
Copy link
Copy Markdown
Contributor Author

The following tests failed on my end, but I failed to see how these tests are related to my change:

  • TestDocument#test_: a document with a date with timezone should have the expected date.
  • TestDocument#test_: a document with a date with timezone should return the expected date via Liquid.
  • TestFilters#test_: filters jsonify filter should convert drop to json.

@brlin-tw
Copy link
Copy Markdown
Contributor Author

brlin-tw commented Oct 11, 2024

For some reason, the unordered list markup broke the .description paragraph:

Screenshot

The corresponding Markdown template seems to be the following file:

https://github.com/jekyll/jekyll/blob/master/docs/_docs/configuration/options.md

but I am unable to figure out how to fix it so I will leave it here.

@ashmaroli
Copy link
Copy Markdown
Member

Thanks @brlin-tw
@jekyllbot: merge +doc

@jekyllbot jekyllbot merged commit 0c4a453 into jekyll:master Oct 20, 2024
jekyllbot added a commit that referenced this pull request Oct 20, 2024
github-actions bot pushed a commit that referenced this pull request Oct 20, 2024
林博仁 Buo-ren Lin: Fix missing glob matching pattern support description in the documentation of the `include` and `exclude` configuration options (#9697)

Merge pull request 9697
@brlin-tw brlin-tw deleted the patch/improve-exclude-include-documentation branch October 20, 2024 17:09
@jekyll jekyll locked and limited conversation to collaborators Oct 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs]: Missing glob matching pattern support description in the documentation of the include and exclude configuration options

3 participants