Render theme-gem root only in development#9680
Merged
jekyllbot merged 2 commits intojekyll:masterfrom Sep 16, 2024
Merged
Conversation
Member
Author
|
@jekyllbot: merge +fix |
jekyllbot
added a commit
that referenced
this pull request
Sep 16, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
Ashwin Maroli: Render theme-gem root only in development (#9680) Merge pull request 9680
ashmaroli
added a commit
to ashmaroli/jekyll
that referenced
this pull request
Sep 16, 2024
…pment This backports 32074ef to 4.3-stable
ashmaroli
added a commit
that referenced
this pull request
Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{{ theme.root }}rendering the absolute path to theme-gem has no value outside development builds.So, render the value only when site is built in development mode explicitly.
NOT A BREAKING CHANGEConsider backport to
4.3-stablebranch.