You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
json gem which is integral to Jekyll's jsonify Liquid filter and Jekyll::Drops::Drop#to_json does not seem to be bundled on some variants of Ruby 3.x based on reports from our users.
Adding a minimum requirement to v2.6.x instead of the newer v2.7.x to give users the option to downgrade if necessary.
Considering this as a "Minor Enhancement" to be shipped with v4.4.
Will backport to 4.3-stable and 3.10-stable if @mattr- and @parkr decides this needs to be backported.
@parkr, the exact situation here is kind of flaky.
I couldn't find any mention of unbundling json gem from ruby/ruby GH repo. But, ever since Ruby 3.0 dropped, there are users commenting here that they had to manually bundle add json to get their set up working with Jekyll:
However, my own Ruby installation v3.2 on Windows still has json both as bundled and as gem at my gem installation location. So, I'm not sure if the Ruby lang maintainers released a particular version with bundling json gem but then subsequent releases had json bundled.
Therefore, for the sake of our users who are on any Ruby version that we claim to support but are not knowledgable of Ruby internals, I decided to have json as a runtime dependency.
Since its a flaky issue, I don't think a backport is warranted.. but your call..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jsongem which is integral to Jekyll'sjsonifyLiquid filter andJekyll::Drops::Drop#to_jsondoes not seem to be bundled on some variants of Ruby 3.x based on reports from our users.Adding a minimum requirement to
v2.6.xinstead of the newerv2.7.xto give users the option to downgrade if necessary.Context
Closes #9499
Resolves #9649