Skip to content

Windows CI on GitHub Actions#9659

Merged
jekyllbot merged 6 commits intojekyll:masterfrom
ashmaroli:win-on-ga
Sep 6, 2024
Merged

Windows CI on GitHub Actions#9659
jekyllbot merged 6 commits intojekyll:masterfrom
ashmaroli:win-on-ga

Conversation

@ashmaroli
Copy link
Copy Markdown
Member

@ashmaroli ashmaroli commented Sep 2, 2024

Summary

Migrating Windows CI from AppVeyor to GitHub Actions

Context

Closes #9636
Closes #9657

@ashmaroli
Copy link
Copy Markdown
Member Author

Hello @parkr, may I request you to uninstall or disable the AppVeyor GitHub App from this repository?

@parkr
Copy link
Copy Markdown
Member

parkr commented Sep 5, 2024

Thanks so much, @ashmaroli! Based on the settings, if you remove the appveyor.yaml file, it should stop building.

@ashmaroli
Copy link
Copy Markdown
Member Author

ashmaroli commented Sep 5, 2024

@parkr The reason I had to monkey-patch a Jekyll core class in test/helper.rb was because unlike AppVeyor and my local windows machine, GitHub Actions on Windows follows the symlink to /etc/password (just like on Linux) but fails because the path /etc/password doesn't exist on a Windows system (which causes File.realpath(...) to fail).

If you get the time to push a new symlink-outside-source test file that points to some file which exists on all platforms (e.g. jekyll.gemspec), I could remove that monkey-patch from this branch after adjusting all test-failures as a side-effect of symlink-change.

Update: Deferred to future pull request(s)

@ashmaroli ashmaroli marked this pull request as ready for review September 6, 2024 06:07
@ashmaroli
Copy link
Copy Markdown
Member Author

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit e300964 into jekyll:master Sep 6, 2024
jekyllbot added a commit that referenced this pull request Sep 6, 2024
@ashmaroli ashmaroli deleted the win-on-ga branch September 6, 2024 06:10
github-actions bot pushed a commit that referenced this pull request Sep 6, 2024
Ashwin Maroli: Windows CI on GitHub Actions (#9659)

Merge pull request 9659
ashmaroli added a commit to ashmaroli/jekyll that referenced this pull request Sep 16, 2024
@jekyll jekyll locked and limited conversation to collaborators Sep 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: CI Appveyor 2.7 builds fail

3 participants