Acknowledge livereload_port from site config too#9606
Merged
jekyllbot merged 1 commit intojekyll:masterfrom Sep 8, 2024
Merged
Acknowledge livereload_port from site config too#9606jekyllbot merged 1 commit intojekyll:masterfrom
livereload_port from site config too#9606jekyllbot merged 1 commit intojekyll:masterfrom
Conversation
ashmaroli
approved these changes
Sep 8, 2024
Member
|
Thanks @gouravkhunger |
jekyllbot
added a commit
that referenced
this pull request
Sep 8, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 8, 2024
Gourav Khunger: fix: acknowledge livereload_port from site config too (#9606) Merge pull request 9606
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 🙋 feature or enhancement.
Summary
The
livereload_portoption is already supported internally but is hardcoded to35729:jekyll/lib/jekyll/commands/serve.rb
Line 55 in 1484c6d
jekyll/lib/jekyll/commands/serve.rb
Line 74 in 1484c6d
In order to give preference to user defined
livereload_portinstead of the hardcoded value, the above line needed to be moved from theinit_with_programfunction toprocess.Context
Fixes #9605